Unverified Commit ff3e4c5c authored by Mudkip's avatar Mudkip Committed by GitHub

fix: avoid truncating memo batch attachments (#5654)

parent 9ecd7b87
...@@ -80,11 +80,12 @@ func (s *Store) CreateAttachment(ctx context.Context, create *Attachment) (*Atta ...@@ -80,11 +80,12 @@ func (s *Store) CreateAttachment(ctx context.Context, create *Attachment) (*Atta
func (s *Store) ListAttachments(ctx context.Context, find *FindAttachment) ([]*Attachment, error) { func (s *Store) ListAttachments(ctx context.Context, find *FindAttachment) ([]*Attachment, error) {
// Set default limits to prevent loading too many attachments at once // Set default limits to prevent loading too many attachments at once
if find.Limit == nil && find.GetBlob { shouldApplyDefaultLimit := find.Limit == nil && len(find.MemoIDList) == 0
if shouldApplyDefaultLimit && find.GetBlob {
// When fetching blobs, we should be especially careful with limits // When fetching blobs, we should be especially careful with limits
defaultLimit := 10 defaultLimit := 10
find.Limit = &defaultLimit find.Limit = &defaultLimit
} else if find.Limit == nil { } else if shouldApplyDefaultLimit {
// Even without blobs, let's default to a reasonable limit // Even without blobs, let's default to a reasonable limit
defaultLimit := 100 defaultLimit := 100
find.Limit = &defaultLimit find.Limit = &defaultLimit
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment