Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
canifa_note
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Vũ Hoàng Anh
canifa_note
Commits
c09ea5a8
Commit
c09ea5a8
authored
Oct 22, 2025
by
Steven
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chore: remove basic filter support from ListAttachments method
parent
2e31bee1
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
24 deletions
+0
-24
attachment_service.go
server/router/api/v1/attachment_service.go
+0
-24
No files found.
server/router/api/v1/attachment_service.go
View file @
c09ea5a8
...
...
@@ -156,35 +156,11 @@ func (s *APIV1Service) ListAttachments(ctx context.Context, request *v1pb.ListAt
Offset
:
&
offset
,
}
// Basic filter support for common cases
if
request
.
Filter
!=
""
{
// Simple filter parsing - can be enhanced later
// For now, support basic type filtering: "type=image/png"
if
strings
.
HasPrefix
(
request
.
Filter
,
"type="
)
{
filterType
:=
strings
.
TrimPrefix
(
request
.
Filter
,
"type="
)
// Create a temporary struct to hold type filter
// Since FindAttachment doesn't have Type field, we'll apply this post-query
_
=
filterType
// We'll filter after getting results
}
}
attachments
,
err
:=
s
.
Store
.
ListAttachments
(
ctx
,
findAttachment
)
if
err
!=
nil
{
return
nil
,
status
.
Errorf
(
codes
.
Internal
,
"failed to list attachments: %v"
,
err
)
}
// Apply type filter if specified
if
request
.
Filter
!=
""
&&
strings
.
HasPrefix
(
request
.
Filter
,
"type="
)
{
filterType
:=
strings
.
TrimPrefix
(
request
.
Filter
,
"type="
)
filteredAttachments
:=
make
([]
*
store
.
Attachment
,
0
)
for
_
,
attachment
:=
range
attachments
{
if
attachment
.
Type
==
filterType
{
filteredAttachments
=
append
(
filteredAttachments
,
attachment
)
}
}
attachments
=
filteredAttachments
}
response
:=
&
v1pb
.
ListAttachmentsResponse
{}
for
_
,
attachment
:=
range
attachments
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment