Skip to content

C
canifa_note
Unverified Commit c0619ef4 authored by Athurg Gooth's avatar Athurg Gooth Committed by GitHub
Browse files
Options

fix: CreateIdentityProvider without id (#2352)

parent b2aa66b4
Hide whitespace changes
Inline Side-by-side
Showing with 20 additions and 29 deletions
store/db/mysql/idp.go
View file @ c0619ef4
...@@ -22,15 +22,16 @@ func (d *DB) CreateIdentityProvider(ctx context.Context, create *store.IdentityP ...@@ -22,15 +22,16 @@ func (d *DB) CreateIdentityProvider(ctx context.Context, create *store.IdentityP
return nil, errors.Errorf("unsupported idp type %s", string(create.Type)) return nil, errors.Errorf("unsupported idp type %s", string(create.Type))
} }
stmt := "INSERT INTO `idp` (`name`, `type`, `identifier_filter`, `config`) VALUES (?, ?, ?, ?)" placeholders := []string{"?", "?", "?", "?"}
result, err := d.db.ExecContext( fields := []string{"`name`", "`type`", "`identifier_filter`", "`config`"}
ctx, args := []any{create.Name, create.Type, create.IdentifierFilter, string(configBytes)}
stmt,
create.Name, if create.ID != 0 {
create.Type, fields, placeholders, args = append(fields, "`id`"), append(placeholders, "?"), append(args, create.ID)
create.IdentifierFilter, }
string(configBytes),
) stmt := "INSERT INTO `idp` (" + strings.Join(fields, ", ") + ") VALUES (" + strings.Join(placeholders, ", ") + ")"
result, err := d.db.ExecContext(ctx, stmt, args...)
if err != nil { if err != nil {
return nil, err return nil, err
} }
......
store/db/sqlite/idp.go
View file @ c0619ef4
...@@ -23,26 +23,16 @@ func (d *DB) CreateIdentityProvider(ctx context.Context, create *store.IdentityP ...@@ -23,26 +23,16 @@ func (d *DB) CreateIdentityProvider(ctx context.Context, create *store.IdentityP
return nil, errors.Errorf("unsupported idp type %s", string(create.Type)) return nil, errors.Errorf("unsupported idp type %s", string(create.Type))
} }
stmt := ` placeholders := []string{"?", "?", "?", "?"}
INSERT INTO idp ( fields := []string{"`name`", "`type`", "`identifier_filter`", "`config`"}
name, args := []any{create.Name, create.Type, create.IdentifierFilter, string(configBytes)}
type,
identifier_filter, if create.ID != 0 {
config fields, placeholders, args = append(fields, "`id`"), append(placeholders, "?"), append(args, create.ID)
) }
VALUES (?, ?, ?, ?)
RETURNING id stmt := "INSERT INTO `idp` (" + strings.Join(fields, ", ") + ") VALUES (" + strings.Join(placeholders, ", ") + ") RETURNING `id`"
` if err := d.db.QueryRowContext(ctx, stmt, args...).Scan(&create.ID); err != nil {
if err := d.db.QueryRowContext(
ctx,
stmt,
create.Name,
create.Type,
create.IdentifierFilter,
string(configBytes),
).Scan(
&create.ID,
); err != nil {
return nil, err return nil, err
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment