fix: list memos with pinned

api/v2/memo_service.go

@@ -130,6 +130,8 @@ func (s *APIV2Service) ListMemos(ctx context.Context, request *apiv2pb.ListMemos
 		if filter.RowStatus != nil {
 			memoFind.RowStatus = filter.RowStatus
 		}
+	} else {
+		return nil, status.Errorf(codes.InvalidArgument, "filter is required")
 	}
 
 	user, _ := getCurrentUser(ctx, s.Store)

store/db/mysql/memo.go

@@ -90,7 +90,7 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 		"UNIX_TIMESTAMP(`memo`.`updated_ts`) AS `updated_ts`",
 		"`memo`.`row_status` AS `row_status`",
 		"`memo`.`visibility` AS `visibility`",
-		"`memo_organizer`.`pinned` AS `pinned`",
+		"IFNULL(`memo_organizer`.`pinned`, 0) AS `pinned`",
 		"`memo_relation`.`related_memo_id` AS `parent_id`",
 	}
 	if !find.ExcludeContent {
@@ -114,7 +114,6 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 	list := make([]*store.Memo, 0)
 	for rows.Next() {
 		var memo store.Memo
-		pinned := sql.NullBool{}
 		dests := []any{
 			&memo.ID,
 			&memo.CreatorID,
@@ -122,7 +121,7 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 			&memo.UpdatedTs,
 			&memo.RowStatus,
 			&memo.Visibility,
-			&pinned,
+			&memo.Pinned,
 			&memo.ParentID,
 		}
 		if !find.ExcludeContent {
@@ -131,9 +130,6 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 		if err := rows.Scan(dests...); err != nil {
 			return nil, err
 		}
-		if pinned.Valid {
-			memo.Pinned = pinned.Bool
-		}
 		list = append(list, &memo)
 	}
 

store/db/postgres/memo.go

@@ -81,7 +81,7 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 		`memo.updated_ts AS updated_ts`,
 		`memo.row_status AS row_status`,
 		`memo.visibility AS visibility`,
-		`memo_organizer.pinned AS pinned`,
+		`COALESCE(memo_organizer.pinned, 0) AS pinned`,
 		`memo_relation.related_memo_id AS parent_id`,
 	}
 	if !find.ExcludeContent {
@@ -110,7 +110,6 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 	list := make([]*store.Memo, 0)
 	for rows.Next() {
 		var memo store.Memo
-		pinned := sql.NullBool{}
 		dests := []any{
 			&memo.ID,
 			&memo.CreatorID,
@@ -118,7 +117,7 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 			&memo.UpdatedTs,
 			&memo.RowStatus,
 			&memo.Visibility,
-			&pinned,
+			&memo.Pinned,
 			&memo.ParentID,
 		}
 		if !find.ExcludeContent {
@@ -127,9 +126,6 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 		if err := rows.Scan(dests...); err != nil {
 			return nil, err
 		}
-		if pinned.Valid {
-			memo.Pinned = pinned.Bool
-		}
 		list = append(list, &memo)
 	}
 

store/db/sqlite/memo.go

@@ -80,7 +80,7 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 		`memo.updated_ts AS updated_ts`,
 		`memo.row_status AS row_status`,
 		`memo.visibility AS visibility`,
-		`memo_organizer.pinned AS pinned`,
+		`IFNULL(memo_organizer.pinned, 0) AS pinned`,
 		`memo_relation.related_memo_id AS parent_id`,
 	}
 	if !find.ExcludeContent {
@@ -109,7 +109,6 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 	list := make([]*store.Memo, 0)
 	for rows.Next() {
 		var memo store.Memo
-		pinned := sql.NullBool{}
 		dests := []any{
 			&memo.ID,
 			&memo.CreatorID,
@@ -117,7 +116,7 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 			&memo.UpdatedTs,
 			&memo.RowStatus,
 			&memo.Visibility,
-			&pinned,
+			&memo.Pinned,
 			&memo.ParentID,
 		}
 		if !find.ExcludeContent {
@@ -126,9 +125,6 @@ func (d *DB) ListMemos(ctx context.Context, find *store.FindMemo) ([]*store.Memo
 		if err := rows.Scan(dests...); err != nil {
 			return nil, err
 		}
-		if pinned.Valid {
-			memo.Pinned = pinned.Bool
-		}
 		list = append(list, &memo)
 	}
 

web/src/pages/Explore.tsx

@@ -42,9 +42,9 @@ const Explore = () => {
     }
     setIsRequesting(true);
     const data = await memoStore.fetchMemos({
+      filter: filters.join(" && "),
       limit: DEFAULT_MEMO_LIMIT,
       offset: memoList.size(),
-      filter: filters.join(" && "),
     });
     setIsRequesting(false);
     setIsComplete(data.length < DEFAULT_MEMO_LIMIT);

web/src/pages/Home.tsx

@@ -52,9 +52,9 @@ const Home = () => {
     }
     setIsRequesting(true);
     const data = await memoStore.fetchMemos({
+      filter: filters.join(" && "),
       limit: DEFAULT_MEMO_LIMIT,
       offset: memoList.size(),
-      filter: filters.join(" && "),
     });
     setIsRequesting(false);
     setIsComplete(data.length < DEFAULT_MEMO_LIMIT);