Commit 8479e1d5 authored by boojack's avatar boojack

test: close SSE response body explicitly

parent a5ddd5ad
...@@ -86,9 +86,12 @@ func TestSSEHandler_Authentication(t *testing.T) { ...@@ -86,9 +86,12 @@ func TestSSEHandler_Authentication(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
req.Header.Set("Authorization", "Bearer "+token) req.Header.Set("Authorization", "Bearer "+token)
resp, err := server.Client().Do(req) resp, err := server.Client().Do(req) //nolint:bodyclose // Body is closed after verifying the SSE stream disconnects.
require.NoError(t, err) if err != nil {
defer resp.Body.Close() t.Fatal(err)
}
body := resp.Body
defer body.Close()
require.Equal(t, http.StatusOK, resp.StatusCode) require.Equal(t, http.StatusOK, resp.StatusCode)
require.Equal(t, "text/event-stream", resp.Header.Get("Content-Type")) require.Equal(t, "text/event-stream", resp.Header.Get("Content-Type"))
...@@ -96,7 +99,7 @@ func TestSSEHandler_Authentication(t *testing.T) { ...@@ -96,7 +99,7 @@ func TestSSEHandler_Authentication(t *testing.T) {
done := make(chan error, 1) done := make(chan error, 1)
go func() { go func() {
_, err := io.ReadAll(resp.Body) _, err := io.ReadAll(body)
done <- err done <- err
}() }()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment