Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
canifa_note
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Vũ Hoàng Anh
canifa_note
Commits
56ceba2d
Unverified
Commit
56ceba2d
authored
May 05, 2024
by
Nabiel Omar Syarif
Committed by
GitHub
May 05, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: fix deleting tag from tag lists (#3311)
parent
e32a585b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
7 deletions
+2
-7
tag_service.go
server/router/api/v1/tag_service.go
+1
-7
TagsSection.tsx
web/src/components/HomeSidebar/TagsSection.tsx
+1
-0
No files found.
server/router/api/v1/tag_service.go
View file @
56ceba2d
...
@@ -137,13 +137,7 @@ func (s *APIV1Service) RenameTag(ctx context.Context, request *v1pb.RenameTagReq
...
@@ -137,13 +137,7 @@ func (s *APIV1Service) RenameTag(ctx context.Context, request *v1pb.RenameTagReq
}
}
func
(
s
*
APIV1Service
)
DeleteTag
(
ctx
context
.
Context
,
request
*
v1pb
.
DeleteTagRequest
)
(
*
emptypb
.
Empty
,
error
)
{
func
(
s
*
APIV1Service
)
DeleteTag
(
ctx
context
.
Context
,
request
*
v1pb
.
DeleteTagRequest
)
(
*
emptypb
.
Empty
,
error
)
{
userID
,
err
:=
ExtractUserIDFromName
(
request
.
Tag
.
Creator
)
user
,
err
:=
getCurrentUser
(
ctx
,
s
.
Store
)
if
err
!=
nil
{
return
nil
,
status
.
Errorf
(
codes
.
InvalidArgument
,
"invalid user name: %v"
,
err
)
}
user
,
err
:=
s
.
Store
.
GetUser
(
ctx
,
&
store
.
FindUser
{
ID
:
&
userID
,
})
if
err
!=
nil
{
if
err
!=
nil
{
return
nil
,
status
.
Errorf
(
codes
.
Internal
,
"failed to get user: %v"
,
err
)
return
nil
,
status
.
Errorf
(
codes
.
Internal
,
"failed to get user: %v"
,
err
)
}
}
...
...
web/src/components/HomeSidebar/TagsSection.tsx
View file @
56ceba2d
...
@@ -130,6 +130,7 @@ const TagItemContainer: React.FC<TagItemContainerProps> = (props: TagItemContain
...
@@ -130,6 +130,7 @@ const TagItemContainer: React.FC<TagItemContainerProps> = (props: TagItemContain
dialogName
:
"delete-tag-dialog"
,
dialogName
:
"delete-tag-dialog"
,
onConfirm
:
async
()
=>
{
onConfirm
:
async
()
=>
{
await
tagStore
.
deleteTag
(
tag
.
text
);
await
tagStore
.
deleteTag
(
tag
.
text
);
tagStore
.
fetchTags
({
skipCache
:
true
});
},
},
});
});
};
};
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment