Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
canifa_note
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Vũ Hoàng Anh
canifa_note
Commits
2e9b9368
Unverified
Commit
2e9b9368
authored
Mar 16, 2025
by
Amir Ehsandar
Committed by
GitHub
Mar 16, 2025
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: prevent double effect on image modal wheel event (#4522)
- escape key closes the modal - zooming is a bit smoother
parent
c0643ff6
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
5 deletions
+13
-5
PreviewImageDialog.tsx
web/src/components/PreviewImageDialog.tsx
+13
-5
No files found.
web/src/components/PreviewImageDialog.tsx
View file @
2e9b9368
...
...
@@ -5,7 +5,7 @@ import { generateDialog } from "./Dialog";
const
MIN_SCALE
=
0.5
;
const
MAX_SCALE
=
5
;
const
SCALE_UNIT
=
0.2
5
;
const
SCALE_UNIT
=
0.2
;
interface
Props
extends
DialogProps
{
imgUrls
:
string
[];
...
...
@@ -95,14 +95,22 @@ const PreviewImageDialog: React.FC<Props> = ({ destroy, imgUrls, initialIndex }:
};
const
handleImageContainerKeyDown
=
(
event
:
KeyboardEvent
)
=>
{
if
(
event
.
key
==
"ArrowLeft"
)
{
showPrevImg
();
}
else
if
(
event
.
key
==
"ArrowRight"
)
{
showNextImg
();
switch
(
event
.
key
)
{
case
"ArrowLeft"
:
showPrevImg
();
break
;
case
"ArrowRight"
:
showNextImg
();
break
;
case
"Escape"
:
destroyAndResetViewport
();
break
;
default
:
}
};
const
handleImgContainerScroll
=
(
event
:
React
.
WheelEvent
)
=>
{
event
.
stopPropagation
();
const
offsetX
=
event
.
nativeEvent
.
offsetX
;
const
offsetY
=
event
.
nativeEvent
.
offsetY
;
const
sign
=
event
.
deltaY
<
0
?
1
:
-
1
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment