• Steven's avatar
    fix(auth): make PKCE optional for OAuth sign-in (#5570) · cf0a285e
    Steven authored
    Fixes issue where OAuth sign-in fails with 'Cannot read properties of
    undefined (reading 'digest')' when accessing Memos over HTTP.
    
    The crypto.subtle API is only available in secure contexts (HTTPS or
    localhost), but PKCE (RFC 7636) is optional per OAuth 2.0 standards.
    
    Changes:
    - Make PKCE generation optional with graceful fallback
    - Use PKCE when crypto.subtle available (HTTPS/localhost)
    - Fall back to standard OAuth flow when unavailable (HTTP)
    - Log warning to console when PKCE unavailable
    - Only include code_challenge in auth URL when PKCE enabled
    
    The backend already supports optional PKCE (empty codeVerifier), so no
    backend changes needed. This fix aligns frontend behavior with backend.
    
    Benefits:
    - OAuth sign-in works on HTTP deployments (reverse proxy scenarios)
    - Enhanced security (PKCE) still used when HTTPS available
    - Backward compatible with OAuth providers that don't support PKCE
    
    Fixes #5570
    cf0a285e
oauth.ts 5.13 KB