Skip to content

C
canifa_note
Unverified Commit c76ffb0f authored by Neo's avatar Neo Committed by GitHub
Browse files
Options

chore: adds a check to only query reactions when there are actual memos (#4984)

parent 1dd25634
Show whitespace changes
Inline Side-by-side
Showing with 10 additions and 8 deletions
server/router/api/v1/memo_service.go
View file @ c76ffb0f
...@@ -186,6 +186,7 @@ func (s *APIV1Service) ListMemos(ctx context.Context, request *v1pb.ListMemosReq ...@@ -186,6 +186,7 @@ func (s *APIV1Service) ListMemos(ctx context.Context, request *v1pb.ListMemosReq
memoNames = append(memoNames, fmt.Sprintf("'%s/%s'", MemoNamePrefix, m.UID)) memoNames = append(memoNames, fmt.Sprintf("'%s/%s'", MemoNamePrefix, m.UID))
} }
if len(memoNames) > 0 {
reactions, err := s.Store.ListReactions(ctx, &store.FindReaction{ reactions, err := s.Store.ListReactions(ctx, &store.FindReaction{
Filters: []string{fmt.Sprintf("content_id in [%s]", strings.Join(memoNames, ", "))}, Filters: []string{fmt.Sprintf("content_id in [%s]", strings.Join(memoNames, ", "))},
}) })
...@@ -196,6 +197,7 @@ func (s *APIV1Service) ListMemos(ctx context.Context, request *v1pb.ListMemosReq ...@@ -196,6 +197,7 @@ func (s *APIV1Service) ListMemos(ctx context.Context, request *v1pb.ListMemosReq
for _, reaction := range reactions { for _, reaction := range reactions {
reactionMap[reaction.ContentID] = append(reactionMap[reaction.ContentID], reaction) reactionMap[reaction.ContentID] = append(reactionMap[reaction.ContentID], reaction)
} }
}
for _, memo := range memos { for _, memo := range memos {
name := fmt.Sprintf("'%s/%s'", MemoNamePrefix, memo.UID) name := fmt.Sprintf("'%s/%s'", MemoNamePrefix, memo.UID)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment