Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
canifa_note
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Vũ Hoàng Anh
canifa_note
Commits
3158c4b8
Unverified
Commit
3158c4b8
authored
Jan 31, 2024
by
Wen Sun
Committed by
GitHub
Jan 31, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: role error in api/v2 when the first user registers (#2875)
Fix role error in api/v2 when the first user registers
parent
30ae4140
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
5 deletions
+9
-5
auth_service.go
api/v2/auth_service.go
+9
-5
No files found.
api/v2/auth_service.go
View file @
3158c4b8
...
@@ -179,7 +179,7 @@ func (s *APIV2Service) SignUp(ctx context.Context, request *apiv2pb.SignUpReques
...
@@ -179,7 +179,7 @@ func (s *APIV2Service) SignUp(ctx context.Context, request *apiv2pb.SignUpReques
if
err
!=
nil
{
if
err
!=
nil
{
return
nil
,
status
.
Errorf
(
codes
.
Internal
,
fmt
.
Sprintf
(
"failed to get workspace setting, err: %s"
,
err
))
return
nil
,
status
.
Errorf
(
codes
.
Internal
,
fmt
.
Sprintf
(
"failed to get workspace setting, err: %s"
,
err
))
}
}
if
workspaceGeneralSetting
.
DisallowSignup
{
if
workspaceGeneralSetting
.
DisallowSignup
||
workspaceGeneralSetting
.
DisallowPasswordLogin
{
return
nil
,
status
.
Errorf
(
codes
.
PermissionDenied
,
"sign up is not allowed"
)
return
nil
,
status
.
Errorf
(
codes
.
PermissionDenied
,
"sign up is not allowed"
)
}
}
...
@@ -193,13 +193,17 @@ func (s *APIV2Service) SignUp(ctx context.Context, request *apiv2pb.SignUpReques
...
@@ -193,13 +193,17 @@ func (s *APIV2Service) SignUp(ctx context.Context, request *apiv2pb.SignUpReques
Nickname
:
request
.
Username
,
Nickname
:
request
.
Username
,
PasswordHash
:
string
(
passwordHash
),
PasswordHash
:
string
(
passwordHash
),
}
}
existingUsers
,
err
:=
s
.
Store
.
ListUsers
(
ctx
,
&
store
.
FindUser
{})
hostUserType
:=
store
.
RoleHost
existedHostUsers
,
err
:=
s
.
Store
.
ListUsers
(
ctx
,
&
store
.
FindUser
{
Role
:
&
hostUserType
,
})
if
err
!=
nil
{
if
err
!=
nil
{
return
nil
,
status
.
Errorf
(
codes
.
Internal
,
fmt
.
Sprintf
(
"failed to list users, err: %s"
,
err
))
return
nil
,
status
.
Errorf
(
codes
.
Internal
,
fmt
.
Sprintf
(
"failed to list users, err: %s"
,
err
))
}
}
// The first user to sign up is an admin by default.
if
len
(
existedHostUsers
)
==
0
{
if
len
(
existingUsers
)
==
0
{
// Change the default role to host if there is no host user.
create
.
Role
=
store
.
Role
Admin
create
.
Role
=
store
.
Role
Host
}
else
{
}
else
{
create
.
Role
=
store
.
RoleUser
create
.
Role
=
store
.
RoleUser
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment