Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
canifa_note
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Vũ Hoàng Anh
canifa_note
Commits
0ee938c3
Commit
0ee938c3
authored
Oct 27, 2023
by
Steven
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chore: remove unused inbox status
parent
3c36cc29
Changes
6
Expand all
Show whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
73 additions
and
84 deletions
+73
-84
inbox_service .go
api/v2/inbox_service .go
+0
-4
inbox_service.proto
proto/api/v2/inbox_service.proto
+1
-2
README.md
proto/gen/api/v2/README.md
+1
-2
inbox_service.pb.go
proto/gen/api/v2/inbox_service.pb.go
+69
-73
inbox.go
store/inbox.go
+0
-1
inbox_test.go
test/store/inbox_test.go
+2
-2
No files found.
api/v2/inbox_service .go
View file @
0ee938c3
...
@@ -119,8 +119,6 @@ func convertInboxStatusFromStore(status store.InboxStatus) apiv2pb.Inbox_Status
...
@@ -119,8 +119,6 @@ func convertInboxStatusFromStore(status store.InboxStatus) apiv2pb.Inbox_Status
switch
status
{
switch
status
{
case
store
.
UNREAD
:
case
store
.
UNREAD
:
return
apiv2pb
.
Inbox_UNREAD
return
apiv2pb
.
Inbox_UNREAD
case
store
.
READ
:
return
apiv2pb
.
Inbox_READ
case
store
.
ARCHIVED
:
case
store
.
ARCHIVED
:
return
apiv2pb
.
Inbox_ARCHIVED
return
apiv2pb
.
Inbox_ARCHIVED
default
:
default
:
...
@@ -132,8 +130,6 @@ func convertInboxStatusToStore(status apiv2pb.Inbox_Status) store.InboxStatus {
...
@@ -132,8 +130,6 @@ func convertInboxStatusToStore(status apiv2pb.Inbox_Status) store.InboxStatus {
switch
status
{
switch
status
{
case
apiv2pb
.
Inbox_UNREAD
:
case
apiv2pb
.
Inbox_UNREAD
:
return
store
.
UNREAD
return
store
.
UNREAD
case
apiv2pb
.
Inbox_READ
:
return
store
.
READ
case
apiv2pb
.
Inbox_ARCHIVED
:
case
apiv2pb
.
Inbox_ARCHIVED
:
return
store
.
ARCHIVED
return
store
.
ARCHIVED
default
:
default
:
...
...
proto/api/v2/inbox_service.proto
View file @
0ee938c3
...
@@ -40,8 +40,7 @@ message Inbox {
...
@@ -40,8 +40,7 @@ message Inbox {
enum
Status
{
enum
Status
{
STATUS_UNSPECIFIED
=
0
;
STATUS_UNSPECIFIED
=
0
;
UNREAD
=
1
;
UNREAD
=
1
;
READ
=
2
;
ARCHIVED
=
2
;
ARCHIVED
=
3
;
}
}
Status
status
=
4
;
Status
status
=
4
;
...
...
proto/gen/api/v2/README.md
View file @
0ee938c3
...
@@ -364,8 +364,7 @@
...
@@ -364,8 +364,7 @@
| ---- | ------ | ----------- |
| ---- | ------ | ----------- |
| STATUS_UNSPECIFIED | 0 | |
| STATUS_UNSPECIFIED | 0 | |
| UNREAD | 1 | |
| UNREAD | 1 | |
| READ | 2 | |
| ARCHIVED | 2 | |
| ARCHIVED | 3 | |
...
...
proto/gen/api/v2/inbox_service.pb.go
View file @
0ee938c3
This diff is collapsed.
Click to expand it.
store/inbox.go
View file @
0ee938c3
...
@@ -11,7 +11,6 @@ type InboxStatus string
...
@@ -11,7 +11,6 @@ type InboxStatus string
const
(
const
(
UNREAD
InboxStatus
=
"UNREAD"
UNREAD
InboxStatus
=
"UNREAD"
READ
InboxStatus
=
"READ"
ARCHIVED
InboxStatus
=
"ARCHIVED"
ARCHIVED
InboxStatus
=
"ARCHIVED"
)
)
...
...
test/store/inbox_test.go
View file @
0ee938c3
...
@@ -36,11 +36,11 @@ func TestInboxStore(t *testing.T) {
...
@@ -36,11 +36,11 @@ func TestInboxStore(t *testing.T) {
require
.
Equal
(
t
,
inbox
,
inboxes
[
0
])
require
.
Equal
(
t
,
inbox
,
inboxes
[
0
])
updatedInbox
,
err
:=
ts
.
UpdateInbox
(
ctx
,
&
store
.
UpdateInbox
{
updatedInbox
,
err
:=
ts
.
UpdateInbox
(
ctx
,
&
store
.
UpdateInbox
{
ID
:
inbox
.
ID
,
ID
:
inbox
.
ID
,
Status
:
store
.
REA
D
,
Status
:
store
.
ARCHIVE
D
,
})
})
require
.
NoError
(
t
,
err
)
require
.
NoError
(
t
,
err
)
require
.
NotNil
(
t
,
updatedInbox
)
require
.
NotNil
(
t
,
updatedInbox
)
require
.
Equal
(
t
,
store
.
REA
D
,
updatedInbox
.
Status
)
require
.
Equal
(
t
,
store
.
ARCHIVE
D
,
updatedInbox
.
Status
)
err
=
ts
.
DeleteInbox
(
ctx
,
&
store
.
DeleteInbox
{
err
=
ts
.
DeleteInbox
(
ctx
,
&
store
.
DeleteInbox
{
ID
:
inbox
.
ID
,
ID
:
inbox
.
ID
,
})
})
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment